Fix Score Postprocessing in QA Task for English and French Versions #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orch.triu which sometimes gives the same start and end indices if the diagonal parameter is not set to 1, and similarly the np.triu with the k parameter.
|
Sorry for the issue, the error is unrelated to your PR! |
|
Yeah I thought so ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed scores postprocessing for the QA task specifically when using
torch.triu, which sometimes gives the same start and end indices if thediagonalparameter is not set to1, and similarly thenp.triuwith thekparameter, which may give same start and end indices ifkis not set to1.